[web-app] Move generic cookie steps to a common parent class #5604
Conversation
Qodana for JVM2 new problems were found
💡 Qodana analysis was run in the pull request mode: only the changed files were checked Contact Qodana teamContact us at qodana-support@jetbrains.com
|
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
| @@ -66,7 +66,7 @@ | |||
|
|
|||
| <bean class="org.vividus.ui.web.playwright.screenshot.PlaywrightScreenshotTaker" /> | |||
|
|
|||
| <bean id="cookieSteps" class="org.vividus.ui.web.playwright.steps.CookieSteps" /> | |||
| <bean id="cookieSteps" class="org.vividus.ui.web.playwright.steps.PlaywrightCookieSteps" /> | |||
Check failure
Code scanning / QDJVM
Incorrect constructor injection in XML Spring bean Error
| @@ -179,7 +179,7 @@ | |||
| <bean id="alertSteps" class="org.vividus.steps.ui.web.AlertSteps" /> | |||
| <bean id="buttonSteps" class="org.vividus.steps.ui.web.RadioButtonSteps" /> | |||
| <bean id="codeSteps" class="org.vividus.steps.ui.web.CodeSteps" /> | |||
| <bean id="cookieSteps" class="org.vividus.steps.ui.web.CookieSteps" /> | |||
| <bean id="cookieSteps" class="org.vividus.steps.ui.web.SeleniumCookieSteps" /> | |||
Check failure
Code scanning / QDJVM
Incorrect constructor injection in XML Spring bean Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #5604 +/- ##
============================================
- Coverage 97.69% 97.69% -0.01%
+ Complexity 7372 7366 -6
============================================
Files 987 988 +1
Lines 20675 20664 -11
Branches 1353 1351 -2
============================================
- Hits 20199 20188 -11
Misses 364 364
Partials 112 112 ☔ View full report in Codecov by Sentry. |
valfirst
force-pushed
the
move-common-cookie-steps-to-a-common-parent-class
branch
from
6fe2505 to
86bada8
Compare
valfirst
force-pushed
the
move-common-cookie-steps-to-a-common-parent-class
branch
from
86bada8 to
d4f69bf
Compare
|
valfirst
deleted the
move-common-cookie-steps-to-a-common-parent-class
branch
No description provided.